Update mod_figures.R #102
Merged
Update mod_figures.R #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elisehinman
commented
Sep 9, 2023
•
elisehinman
commented
- fixed issue Selena discovered - plot subsetting was originally incorrect
- added more narrative to the plots below the map.
- added "error" message when user tries to plot site that does not have first characteristic in dataset.
- fixed bug with two-characteristic scatterplot using incorrect column for plotting.
- fixed issue Selena discovered - plot subsetting was originally incorrect - added more narrative to the plots below the map.
- create error message when user selects single site that does not have the first characteristic sampled. This removes the coding error in the shiny app, but likely is not the most clear design of this part of the app.
found another bug in the two-characteristic scatterplot! fixed.
one last clean up to increase clarity
cristinamullin
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.